Re: svgalib1.9.17 and valgrind FIXED

Search this archive.

From: Matan Ziv-Av (matan@svgalib.org)
Date: Sun 09 Feb 2003 - 21:47:25 IST


On Sun, 9 Feb 2003, James Wright wrote:

> int __svgalib_pci_read_config_dword(int pos, int address)
> {
>   pcic_t p;
>   p.pcipos = pos;
>   p.address = address;
>   p.val = 0; /*********** I INSERTED THIS LINE to initialise the return value ***********/
>   if(ioctl( __svgalib_mem_fd, SVGALIB_HELPER_IOCGPCIINL, &p)) return -1;
>   return p.val;
> };
> 
> Is that the correct thing to do???Shal i go through as many errors as i can with "valgrind"
> to try and clean it up? or is this a waste of time????

It's not a waste of time, but if you want to do it, you will need to
spend a lot of time.
The correct thing to do is to teach valgrind about svgalib's ioctls, so
it knows which values are read/written by those calls.


-- 
Matan Ziv-Av.                         matan@svgalib.org



------------------------------------------------------------------
Unsubscribe:  To:   listbot@svgalib.org
              Body: unsubscribe linux-svgalib


This archive was generated by hypermail 2.1.4 : Wed 21 Jan 2004 - 22:10:25 IST