Re: memory leak

Search this archive.

From: Robin (uijtdeboogaardt@quicknet.nl)
Date: Wed 11 Oct 2000 - 17:49:15 IST


On 10 Oct 2000, (at 22:50), Matan Ziv-Av wrote:

> > In svgalib 1.4.2 it seems while switching consoles, from
> > a svga program to textmode console it 'leaks' about
> > 10 allocations.
> 
> I don't see this, can you please give more details about the situation
> in which you see this?

Hi,

I found out that the leaking allocations where caused by 1
particular function. The card/driver specific ..._modeavailable(
function (eg sis_modeavailable()). 
For some drivers the functions where ok, some weren't. (including 
skeleton.c)

Example (1.4.2) :

vesa.c (with line numbering) :
    
102:static int vesa_modeavailable(int mode)
103:{
104:    struct info *info;
105:    ModeTiming *modetiming;
106:    ModeInfo *modeinfo;
    
107:    modeinfo = 
__svgalib_createModeInfoStructureForSvgalibMode(mode);
    
108:    if ((mode < G640x480x256 )
109:	|| mode == G720x348x2)
110:	return __svgalib_vga_driverspecs.modeavailable(mode);
    
111:    info = &__svgalib_infotable[mode];
    
112:    modeinfo = 
__svgalib_createModeInfoStructureForSvgalibMode(mode);
    

The allocation caused in line 107 is never freed, and actually
never used. Removing this lines solves the problem.

Is this fixed in the current release ?

- Robin.


------------------------------------------------------------------
Unsubscribe:  To:   listbot@svgalib.org
              Body: unsubscribe linux-svgalib


This archive was generated by hypermail 2.1.4 : Wed 21 Jan 2004 - 22:10:23 IST